linux-kernel - Re: [BUG] libmount misparses mountinfo on Linux v2.6.39-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 01 Apr 2011 13:16:23 +0530
From:	"Aneesh Kumar K. V" <aneesh.kumar@...ux.vnet.ibm.com>
To:	victor.vde@...il.com, util-linux@...r.kernel.org,
	Miklos Szeredi <miklos@...redi.hu>, linuxram@...ibm.com
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	Victor van den Elzen <victor.vde@...il.com>,
	"Eugene J. Markow" <ejmarkow@...oo.com>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [BUG] libmount misparses mountinfo on Linux v2.6.39-rc1

On Thu, 31 Mar 2011 22:24:01 +0200, victor.vde@...il.com wrote:
> /proc/self/mountinfo on Linux v2.6.39-rc1 includes the UUID of ext4
> and ext3 mounts, for example:
> 
> 15 1 8:3 / / rw,noatime uuid:c645234d-9756-4d84-825e-6fe999252a34 - ext4 /dev/sda3 rw,user_xattr,acl,barrier=1,data=ordered
> 
> It seems the hyphens in the uuid confuse the parser
> mnt_parse_mountinfo_line in tab_parse.c of libmount in util-linux.

shouldn't the parser look for " " followed by "-" followed by " " as the
field seperator ? 

I am adding Miklos and Ram Pai to CC to check whether the kernel or the libmount 
should be fixed ?

> 
> My util-linux version is 2.19-4 Arch Linux.
> 
> ~ $ findmnt -l /
> TARGET SOURCE FSTYPE                      OPTIONS
> /      -      9756-4d84-825e-6fe999252a34 rw,noatime,ext4
> 
> For reference, the commits in Linus' tree that introduced these uuids
> are:
> 
> 93f1c20bc8cdb757be50566eff88d65c3b26881f vfs: Export file system uuid via /proc/<pid>/mountinfo
> 03cb5f03dcb26846fcad345d8c15aae91579a53d ext3: Copy fs UUID to superblock.
> f2fa2ffc2046fdc35f96366d1ec8675f4d578522 ext4: Copy fs UUID to superblock

-aneesh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/