linux-kernel - Re: [PATCH 01/14] x86-32, NUMA: Fix failure condition check in alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D9B4F69.5050807@kernel.org>
Date:	Tue, 05 Apr 2011 10:20:41 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Tejun Heo <tj@...nel.org>
CC:	mingo@...hat.com, hpa@...or.com, tglx@...utronix.de,
	rientjes@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/14] x86-32, NUMA: Fix failure condition check in alloc_remap()

On 04/04/2011 03:23 PM, Tejun Heo wrote:
> node_remap_{start|end}_vaddr[] describe [start, end) ranges; however,
> alloc_remap() incorrectly failed when the current allocation + size
> equaled the end but it should fail only when it goes over.  Fix it.
>
> Signed-off-by: Tejun Heo<tj@...nel.org>
> Cc: Yinghai Lu<yinghai@...nel.org>
> Cc: David Rientjes<rientjes@...gle.com>
> Cc: Thomas Gleixner<tglx@...utronix.de
> Cc: Ingo Molnar<mingo@...hat.com>
> Cc: "H. Peter Anvin"<hpa@...or.com>
> ---
>   arch/x86/mm/numa_32.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/mm/numa_32.c b/arch/x86/mm/numa_32.c
> index bde3906..84aac47 100644
> --- a/arch/x86/mm/numa_32.c
> +++ b/arch/x86/mm/numa_32.c
> @@ -200,7 +200,7 @@ void *alloc_remap(int nid, unsigned long size)
>
>   	size = ALIGN(size, L1_CACHE_BYTES);
>
> -	if (!allocation || (allocation + size)>= node_remap_end_vaddr[nid])
> +	if (!allocation || (allocation + size)>  node_remap_end_vaddr[nid])
>   		return NULL;
>
>   	node_remap_alloc_vaddr[nid] += size;

Acked-by: Yinghai Lu <yinghai@...nel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/