linux-kernel - Re: [PATCH 02/14] x86-32, NUMA: Align pgdat size while initializing alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D9B5151.6040604@kernel.org>
Date:	Tue, 05 Apr 2011 10:28:49 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Tejun Heo <tj@...nel.org>
CC:	mingo@...hat.com, hpa@...or.com, tglx@...utronix.de,
	rientjes@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/14] x86-32, NUMA: Align pgdat size while initializing
 alloc_remap

On 04/04/2011 03:23 PM, Tejun Heo wrote:
> When pgdat is reserved in init_remap_allocator(), PAGE_SIZE aligned
> size will be used.  Match the size alignment in initialization to
> avoid allocation failure down the road.
>
> Signed-off-by: Tejun Heo<tj@...nel.org>
> Cc: Yinghai Lu<yinghai@...nel.org>
> Cc: David Rientjes<rientjes@...gle.com>
> Cc: Thomas Gleixner<tglx@...utronix.de
> Cc: Ingo Molnar<mingo@...hat.com>
> Cc: "H. Peter Anvin"<hpa@...or.com>
> ---
>   arch/x86/mm/numa_32.c |    3 ++-
>   1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/mm/numa_32.c b/arch/x86/mm/numa_32.c
> index 84aac47..50e8250 100644
> --- a/arch/x86/mm/numa_32.c
> +++ b/arch/x86/mm/numa_32.c
> @@ -287,7 +287,8 @@ static __init unsigned long calculate_numa_remap_pages(void)
>   			node_end_pfn[nid] = max_pfn;
>
>   		/* ensure the remap includes space for the pgdat. */
> -		size = node_remap_size[nid] + sizeof(pg_data_t);
> +		size = node_remap_size[nid];
> +		size += ALIGN(sizeof(pg_data_t), PAGE_SIZE);
>
>   		/* convert size to large (pmd size) pages, rounding up */
>   		size = (size + LARGE_PAGE_BYTES - 1) / LARGE_PAGE_BYTES;

Acked-by: Yinghai Lu <yinghai@...nel.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/