linux-kernel - Re: [PATCH v2] generic-ipi: Initialize call_single

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110407134046.GA27778@redhat.com>
Date:	Thu, 7 Apr 2011 09:40:46 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Takao Indoh <indou.takao@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org, kexec@...ts.infradead.org,
	Milton Miller <miltonm@....com>, Jens Axboe <axboe@...nel.dk>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...e.hu>,
	WANG Cong <xiyou.wangcong@...il.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH v2] generic-ipi: Initialize call_single_queue before
 enabling interrupt

On Wed, Apr 06, 2011 at 06:52:27PM -0400, Takao Indoh wrote:
> On Wed, 06 Apr 2011 18:47:36 -0400, Takao Indoh wrote:
> 
> >On Wed, 6 Apr 2011 16:47:42 -0400, Vivek Goyal wrote:
> >
> >>On Tue, Mar 29, 2011 at 12:35:04PM -0400, Takao Indoh wrote:
> >>> Hi all,
> >>> 
> >>> This patch renames init_call_single_data() to call_function_init() and
> >>> calls it in start_kernel() so that call_single_queue can be initialized
> >>> before enabling interrupt.
> >>> 
> >>> There is a problem that kdump(2nd kernel) sometimes hangs up due to
> >>> pending IPI from 1st kernel. Kernel panic occurs because IPI comes
> >>> before call_single_queue is initialized. The details are as follows.
> >>> (1) 2nd kernel boot up
> >>> (2) A pending IPI from 1st kernel comes when irqs are first enabled
> >>>     in start_kernel().
> >>> (3) Kernel tries to handle the interrupt, but call_single_queue is not
> >>>     initialized yet at this point. As a result, in the
> >>>     generic_smp_call_function_single_interrupt(), NULL pointer
> >>>     dereference occurs when list_replace_init() tries to access
> >>>     &q->list.next.
> >>> Therefore this patch changes the name of init_call_single_data() to
> >>> call_function_init() and calls it before local_irq_enable() in
> >>> start_kernel().
> >>> 
> >>> v2:
> >>> - Rename init_call_single_data() to call_function_init() and calls it in
> >>>   start_kernel()
> >>> - Change insert position in start_kernel().
> >>> - Adjust for CONFIG_SMP/CONFIG_USE_GENERIC_SMP_HELPERS options
> >>> - Rebased to Linus's latest tree
> >>> 
> >>> v1:
> >>> https://lkml.org/lkml/2011/3/25/317
> >>> - Divide init_call_single_data() into two functions,
> >>>    o init_call_single_data: initialize call_single_queue
> >>>    o init_hotplug_cfd: initialize hotplug_cfd_notifier
> >>>   And call init_call_single_data before local_irq_enable() in
> >>>   start_kernel().
> >>> 
> >>> v0:
> >>> https://lkml.org/lkml/2011/3/23/417
> >>> - In generic_smp_call_function_single_interrupt(), check if
> >>>   call_single_queue was initialized or not, and just return if not
> >>>   initialized.
> >>> 
> >>> Signed-off-by: Takao Indoh <indou.takao@...fujitsu.com>

[..]
> >So, list_empty(list)? is always false, if I am not missing something.
> 
> No, list_empty(list)? is always *true*.
> 

ok, I got it. So list_replace_init() is fine even if q->list is empty. So
when a pending IPI from previous kernel comes, q->list will be empty
and we will simply do nothing. Sounds reaosnable to me.

Acked-by: Vivek Goyal <vgoyal@...hat.com>

Thanks
Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/