linux-kernel - Re: [PATCH] module: Use the binary search for symbols resolution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D9DC0E8.5080705@windriver.com>
Date:	Thu, 07 Apr 2011 08:49:28 -0500
From:	Jason Wessel <jason.wessel@...driver.com>
To:	Alessio Igor Bogani <abogani@...nel.org>
CC:	Rusty Russell <rusty@...tcorp.com.au>,
	LKML <linux-kernel@...r.kernel.org>,
	Tim Bird <tim.bird@...sony.com>
Subject: Re: [PATCH] module: Use the binary search for symbols resolution

On 04/05/2011 12:22 PM, Alessio Igor Bogani wrote:
> Let the linker sort the exported symbols and use the binary search for locate them.
>

It would be nice if this patch header included some of the information from introduction message, that asside the technical content looks good.

> This work was supported by a hardware donation from the CE Linux Forum.
>
> Signed-off-by: Alessio Igor Bogani <abogani@...nel.org>

Reviewed-by: Jason Wessel <jason.wessel@...driver.com>


>  static bool find_symbol_in_section(const struct symsearch *syms,
>  				   struct module *owner,
>  				   unsigned int symnum, void *data)
>  {
>  	struct find_symbol_arg *fsa = data;
>  
> -	if (strcmp(syms->start[symnum].name, fsa->name) != 0)
> -		return false;
> -
>  	if (!fsa->gplok) {
>  		if (syms->licence == GPL_ONLY)
>  			return false;


This was the only part I had a hard time following, but after having looked at the original source to kernel/module.c, I see how this was optimized and agree.

This looks like a very nice speed up for large interdependent kernel modules.

Cheers,
Jason.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/