linux-kernel - Re: [PATCH] PCI: Enable ASPM state clearing regardless of policy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110407152310.5bfeab8b.akpm@linux-foundation.org>
Date:	Thu, 7 Apr 2011 15:23:10 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Alex Williamson <alex.williamson@...hat.com>
Cc:	linux-pci@...r.kernel.org, jbarnes@...tuousgeek.org,
	linux-kernel@...r.kernel.org, mjg@...hat.com
Subject: Re: [PATCH] PCI: Enable ASPM state clearing regardless of policy

On Thu, 10 Mar 2011 11:54:16 -0700
Alex Williamson <alex.williamson@...hat.com> wrote:

> Commit 2f671e2d allowed us to clear ASPM state when the FADT
> tells us it isn't supported, but we don't put this into effect
> if the aspm_policy is set to POLICY_POWERSAVE.  Enable the
> state to be cleared regardless of policy.
> 
> Signed-off-by: Alex Williamson <alex.williamson@...hat.com>
> ---
> 
>  drivers/pci/pcie/aspm.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/pci/pcie/aspm.c b/drivers/pci/pcie/aspm.c
> index 3188cd9..eb8ac5c 100644
> --- a/drivers/pci/pcie/aspm.c
> +++ b/drivers/pci/pcie/aspm.c
> @@ -607,7 +607,7 @@ void pcie_aspm_init_link_state(struct pci_dev *pdev)
>  	 * the BIOS's expectation, we'll do so once pci_enable_device() is
>  	 * called.
>  	 */
> -	if (aspm_policy != POLICY_POWERSAVE) {
> +	if (aspm_policy != POLICY_POWERSAVE || aspm_clear_state) {
>  		pcie_config_aspm_path(link);
>  		pcie_set_clkpm(link, policy_to_clkpm_state(link));
>  	}

hm.  why.  Presumably this change has some user-observeable effect.

What is that effect, and why is it desirable? ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/