linux-kernel - Re: [PATCH 2/2] make new alloc_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.vtmfhqyh3l0zgt@mnazarewicz-glaptop>
Date:	Fri, 08 Apr 2011 15:23:40 +0200
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	"Dave Hansen" <dave@...ux.vnet.ibm.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	"Timur Tabi" <timur@...escale.com>,
	"Andi Kleen" <andi@...stfloor.org>, "Mel Gorman" <mel@....ul.ie>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: [PATCH 2/2] make new alloc_pages_exact()

>> On Thu, 07 Apr 2011 19:21:05 +0200, Dave Hansen wrote:
>>>  		while (used < alloc_end) {
>>> -			free_page(used);
>>> -			used += PAGE_SIZE;
>>> +			__free_page(used);
>>> +			used++;
>>>  		}

> On Fri, 2011-04-08 at 14:28 +0200, Michal Nazarewicz wrote:
>> Have you thought about moving this loop to a separate function, ie.
>> _free_page_range(start, end)?  I'm asking because this loop appears
>> in two places and my CMA would also benefit from such a function.

On Fri, 08 Apr 2011 15:19:46 +0200, Dave Hansen wrote:
> Sounds like a good idea to me.  Were you thinking start/end 'struct
> page's as arguments?

Either that or (struct page *start, unsigned nr_pages).

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@...gle.com>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/