linux-kernel - Re: [PATCH v4] USB host: Fix lockdep warning in AMD PLL quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1104081229370.1992-100000@iolanthe.rowland.org>
Date:	Fri, 8 Apr 2011 12:30:12 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	"Roedel, Joerg" <Joerg.Roedel@....com>
cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	"Xu, Andiry" <Andiry.Xu@....com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"stable@...nel.org" <stable@...nel.org>
Subject: Re: [PATCH v4] USB host: Fix lockdep warning in AMD PLL quirk

On Fri, 8 Apr 2011, Roedel, Joerg wrote:

> > > +	info = amd_chipset;
> > 
> > What's the point of this line?  You're just going to write over all the 
> > data in info anyway, so it doesn't matter what amd_chipset contains.  A 
> > memset would work just as well.
> 
> info is on-stack and needs to be initialized somehow because the
> following code does not touch the whole data structure.

Then just use memset.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/