linux-kernel - Re: [RFC][WAS:bcmai][PATCH V2] axi: add AXI bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 9 Apr 2011 02:03:03 +0200
From:	Rafał Miłecki <zajec5@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-wireless@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>,
	George Kashperko <george@...u.edu.ua>,
	Arnd Bergmann <arnd@...db.de>,
	Russell King <rmk@....linux.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	b43-dev@...ts.infradead.org,
	Michael Büsch <mb@...sch.de>,
	linuxdriverproject <devel@...uxdriverproject.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [RFC][WAS:bcmai][PATCH V2] axi: add AXI bus driver

2011/4/8 Joe Perches <joe@...ches.com>:
> On Fri, 2011-04-08 at 21:46 +0200, Rafał Miłecki wrote:
>> 2011/4/8 Joe Perches <joe@...ches.com>:
>> > On Fri, 2011-04-08 at 21:45 +0200, Rafał Miłecki wrote:
>> >> diff --git a/include/linux/axi/axi.h b/include/linux/axi/axi.h
>> > []
>> >> +#define axi_info     pr_info
>> >> +#ifdef CONFIG_AXI_DEBUG
>> >> +#define axi_debug    pr_debug
>> >> +#else
>> >> +#define axi_debug    do { } while (0)
>> >> +#endif
>> >> +#define axi_err              pr_err
>> >
>> > I think redefining standard functionality like
>> > this doesn't gain anything and loses some basic
>> > grep capability.
>>
>> But on the other hand using:
>> pr_info, pr_err, BUT axi_debug
>> can easily lead to mistakes.
>>
>> Or is this possible to re-define pr_debug locally?
>
> It is, but is that CONFIG_AXI_DEBUG actually
> worthwhile?
>
> If you think so, doesn't adding this to the Makefile
> give you the same capability?
>
> ccflags-$(CONFIG_CONFIG_AXI_DEBUG) := -DDEBUG

But pr_debug does not depend on DEBUG define:
http://lxr.free-electrons.com/source/tools/perf/util/include/linux/kernel.h#L94

How do you expect -DDEBUG to affect pr_debug? Could you explain this
to me, please?

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/