linux-kernel - Re: [RFC][WAS:bcmai][PATCH V2] axi: add AXI bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTin_-hhcexTd67HviTqM4bjXMZxweA@mail.gmail.com>
Date:	Sat, 9 Apr 2011 01:46:29 +0200
From:	Rafał Miłecki <zajec5@...il.com>
To:	Greg KH <greg@...ah.com>
Cc:	linux-wireless@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>,
	George Kashperko <george@...u.edu.ua>,
	Arnd Bergmann <arnd@...db.de>,
	Russell King <rmk@....linux.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	b43-dev@...ts.infradead.org,
	Michael Büsch <mb@...sch.de>,
	linuxdriverproject <devel@...uxdriverproject.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [RFC][WAS:bcmai][PATCH V2] axi: add AXI bus driver

2011/4/9 Greg KH <greg@...ah.com>:
>> +static void axi_release_core_dev(struct device *dev)
>> +{
>> +     kfree(dev);
>> +}
>
> This is wrong, unless you are really only creating a 'struct device'.
> Why are you doing that instead of embedding struct device in your
> structure?

Hm, I think Greg found explanation why we can not reload axi driver
successfully :)

I'll take care of your comment after weekend, thank you everybody.

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/