linux-kernel - Re: [Xen-devel] [PATCH 2/4] x86, xen: introduce x86_init.mapping.pagetable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <4DA458AB020000780003B107@vpn.id2.novell.com>
Date:	Tue, 12 Apr 2011 12:50:35 +0100
From:	"Jan Beulich" <JBeulich@...ell.com>
To:	"Stefano Stabellini" <stefano.stabellini@...citrix.com>
Cc:	<mingo@...e.hu>, <jeremy@...p.org>, <yinghai@...nel.org>,
	<hpa@...ux.intel.com>, <xen-devel@...ts.xensource.com>,
	<konrad.wilk@...cle.com>, <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [Xen-devel] [PATCH 2/4] x86, xen: introduce
	 x86_init.mapping.pagetable_reserve

>>> On 12.04.11 at 13:19, <stefano.stabellini@...citrix.com> wrote:
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index 6b833db..fec8680 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -1275,6 +1275,20 @@ static __init void xen_pagetable_setup_start(pgd_t 
> *base)
>  {
>  }
>  
> +static __init void xen_mapping_pagetable_reserve(u64 start, u64 end)
> +{
> +	/* reserve the range used */
> +	memblock_x86_reserve_range(start, end, "PGTABLE");

Wouldn't it be more natural (and involving less future changes) if
you called native_pagetable_reserve() here?

Jan

> +
> +	/* set as RW the rest */
> +	printk(KERN_DEBUG "xen: setting RW the range %llx - %llx\n", end,
> +			PFN_PHYS(pgt_buf_top));
> +	while (end < PFN_PHYS(pgt_buf_top)) {
> +		make_lowmem_page_readwrite(__va(end));
> +		end += PAGE_SIZE;
> +	}
> +}
> +
>  static void xen_post_allocator_init(void);
>  
>  static __init void xen_pagetable_setup_done(pgd_t *base)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/