linux-kernel - Re: [RFC][PATCH V3] axi: add AXI bus driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 12 Apr 2011 08:14:53 -0700
From:	Greg KH <greg@...ah.com>
To:	Rafał Miłecki <zajec5@...il.com>
Cc:	linux-wireless@...r.kernel.org,
	"John W. Linville" <linville@...driver.com>,
	George Kashperko <george@...u.edu.ua>,
	Arnd Bergmann <arnd@...db.de>,
	Russell King <rmk@....linux.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	b43-dev@...ts.infradead.org,
	Michael Büsch <mb@...sch.de>,
	linuxdriverproject <devel@...uxdriverproject.org>,
	Andy Botting <andy@...ybotting.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Larry Finger <Larry.Finger@...inger.net>
Subject: Re: [RFC][PATCH V3] axi: add AXI bus driver

On Tue, Apr 12, 2011 at 07:41:18AM +0200, Rafał Miłecki wrote:
> > You can't do that, no static struct devices please.  Make these dynamic
> > and everything will be fine.  The -mm tree used to have a huge warning
> > if you ever tried to register a statically allocated struct, but that
> > didn't really work out, but would have saved you a lot of time here,
> > sorry.
> >
> > So dynamically allocate the structures and you will be fine.
> 
> Well, I saw that along kernel, I had no idea there is anything wrong
> about this. It seems more ppl do not know about this:
> struct radeon_ib	ibs[RADEON_IB_POOL_SIZE];
> struct radeon_pm_clock_info clock_info[8];
> struct radeon_pm_profile profiles[PM_PROFILE_MAX];
> struct radeon_surface_reg surface_regs[RADEON_GEM_MAX_SURFACES];

Are you sure these are all containing a 'struct device'?

> struct radeon_i2c_chan *i2c_bus[RADEON_MAX_I2C_BUS];

This is an array of pointers, that's fine.

> struct b43_key key[B43_NR_GROUP_KEYS * 2 + B43_NR_PAIRWISE_KEYS];

This contains a 'struct device'?

> struct ssb_device devices[SSB_MAX_NR_CORES];
> I guess I could fine more examples by simple grepping .h files.

Then all of the above should be fixed.

> Is there some guide around with things like this we should avoid?

Yes, do not statically allocate a 'struct device'.

> checkpatch does no catch this, so maybe just some manual? Could you
> point me to it?

It's a structure that has dynamic lifetime rules, you can't statically
allocate it safely.  It's that simple.

Please fix this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/