linux-kernel - Re: [PATCH 1/4] xen: mask_rw_pte mark RO all pagetable pages up to pgt_buf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110412164745.GB1067@dumpdata.com>
Date:	Tue, 12 Apr 2011 12:47:45 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	stefano.stabellini@...citrix.com
Cc:	linux-kernel@...r.kernel.org, xen-devel@...ts.xensource.com,
	jeremy@...p.org, yinghai@...nel.org, hpa@...ux.intel.com,
	mingo@...e.hu
Subject: Re: [PATCH 1/4] xen: mask_rw_pte mark RO all pagetable pages up to
 pgt_buf_top

On Tue, Apr 12, 2011 at 12:19:49PM +0100, stefano.stabellini@...citrix.com wrote:
> From: Stefano Stabellini <stefano.stabellini@...citrix.com>
> 
> mask_rw_pte is currently checking if a pfn is a pagetable page if it
> falls in the range pgt_buf_start - pgt_buf_end but that is incorrect
> because pgt_buf_end is a moving target: pgt_buf_top is the real
> boundary.

OK. Stuck it on the queue for rc3.

> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
> ---
>  arch/x86/xen/mmu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index c82df6c..6b833db 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -1491,7 +1491,7 @@ static __init pte_t mask_rw_pte(pte_t *ptep, pte_t pte)
>  	 * it is RO.
>  	 */
>  	if (((!is_early_ioremap_ptep(ptep) &&
> -			pfn >= pgt_buf_start && pfn < pgt_buf_end)) ||
> +			pfn >= pgt_buf_start && pfn < pgt_buf_top)) ||
>  			(is_early_ioremap_ptep(ptep) && pfn != (pgt_buf_end - 1)))
>  		pte = pte_wrprotect(pte);
>  
> -- 
> 1.7.2.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/