linux-kernel - Re: [PATCH 1/4]percpu_counter: make API return consistent value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1302657855.3981.153.camel@sli10-conroe>
Date:	Wed, 13 Apr 2011 09:24:15 +0800
From:	Shaohua Li <shaohua.li@...el.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"cl@...ux.com" <cl@...ux.com>
Subject: Re: [PATCH 1/4]percpu_counter: make API return consistent value

On Wed, 2011-04-13 at 02:49 +0800, Tejun Heo wrote:
> Hello,
> 
> First of all, please somehow link patches of the same series.  Either
> write a head message and make all the patches replies to it
> (preferred) or chain reply the patches (only when the number of
> patches is small).
> 
> On Tue, Apr 12, 2011 at 04:03:57PM +0800, Shaohua Li wrote:
> > the percpu_counter_*_positive() API SMP and !SMP aren't consistent. From
> > the API name, we should return a non-negative value for them.
> > Also if count < 0, returns 0 instead of 1 for *read_positive().
> 
> Ummm, on UP, the counters cannot be positive.
s/positive/negative?

>   The _positive interface
> is there to make it easier to cope with deviations introduced by
> unsynchronized modifications by different CPUs.  On UP, such
> deviations don't happen at all so _positive interface is the same as
> the counterpart without the postfix.
I'm confused. the counter could be negative, we have *_dec, *_sub.

Thanks,
Shaohua

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/