linux-kernel - Re: [Regression] 2.6.38 ncpfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 15 Apr 2011 10:53:50 +0200
From:	"Dr. Bernd Feige" <bernd.feige@...klinik-freiburg.de>
To:	Bongani Hlope <bonganih@...kservafrica.com>
Cc:	torvalds@...ux-foundation.org, arnd@...db.de, npiggin@...nel.dk,
	greg@...ah.com, hch@....de, bonganilinux@...b.co.za, rjw@...k.pl,
	petr@...drovec.name, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [Regression] 2.6.38 ncpfs

Hi Bongani, Linus et al.

> > You might also try to replace it with
> > 
> >     BUG_ON(!mutex_is_locked(&dentry->d_parent->d_inode->i_mutex))
> > 
> > ie add that "d_parent" there. Just for testing - I think the real fix
> > really is to remove it, but I'd personally be happier knowing that
> > _if_ it were to have that d_parent there, it would have worked.
> 
> I've made that change and ncpfs works fine with it. I've attached a
> patch that changes the BUG_ON to look at the parent.

Seconded, checked it with the Novell servers in our clinic and it works
like a charm - even with the large directories for which I still have to
revert commit 3825bdb7ed920845961f32f364454bee5f469abb from 2.6.37.6
(https://lkml.org/lkml/2011/1/26/302). Thanks a lot!

Bernd


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/