linux-kernel - Re: [PATCH 00/12] IO-less dirty throttling v7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTimY3t6Kc-+=00k3QR+AK2uqJpph4g@mail.gmail.com>
Date:	Sat, 16 Apr 2011 18:27:58 +0200
From:	Sedat Dilek <sedat.dilek@...glemail.com>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, Jan Kara <jack@...e.cz>,
	Christoph Hellwig <hch@....de>,
	Trond Myklebust <Trond.Myklebust@...app.com>,
	Dave Chinner <david@...morbit.com>,
	"Theodore Ts'o" <tytso@....edu>,
	Chris Mason <chris.mason@...cle.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Mel Gorman <mel@....ul.ie>, Rik van Riel <riel@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Greg Thelen <gthelen@...gle.com>,
	Minchan Kim <minchan.kim@...il.com>,
	Vivek Goyal <vgoyal@...hat.com>,
	Andrea Righi <arighi@...eler.com>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	linux-mm <linux-mm@...ck.org>, linux-fsdevel@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 00/12] IO-less dirty throttling v7

On Sat, Apr 16, 2011 at 3:25 PM, Wu Fengguang <fengguang.wu@...el.com> wrote:
> Andrew,
>
> This revision undergoes a number of simplifications, cleanups and fixes.
> Independent patches are separated out. The core patches (07, 08) now have
> easier to understand changelog. Detailed rationals can be found in patch 08.
>
> In response to the complexity complaints, an introduction document is
> written explaining the rationals, algorithm and visual case studies:
>
> http://www.kernel.org/pub/linux/kernel/people/wfg/writeback/slides/smooth-dirty-throttling.pdf
>
> The full patchset is accessible in
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wfg/writeback.git dirty-throttling-v7
>
> Questions, reviews and independent tests will be highly appreciated.
>
> supporting functionalities
>
>        [PATCH 01/12] writeback: account per-bdi accumulated written pages
>        [PATCH 02/12] writeback: account per-bdi accumulated dirtied pages
>        [PATCH 03/12] writeback: bdi write bandwidth estimation
>        [PATCH 04/12] writeback: smoothed global/bdi dirty pages
>        [PATCH 05/12] writeback: smoothed dirty threshold and limit
>        [PATCH 06/12] writeback: enforce 1/4 gap between the dirty/background thresholds
>
> core changes
>
>        [PATCH 07/12] writeback: base throttle bandwidth and position ratio
>        [PATCH 08/12] writeback: IO-less balance_dirty_pages()
>
> tracing
>
>        [PATCH 09/12] writeback: show bdi write bandwidth in debugfs
>        [PATCH 10/12] writeback: trace dirty_ratelimit
>        [PATCH 11/12] writeback: trace balance_dirty_pages
>        [PATCH 12/12] writeback: trace global_dirty_state
>
>  fs/fs-writeback.c                |    3
>  include/linux/backing-dev.h      |   23
>  include/linux/sched.h            |    8
>  include/linux/writeback.h        |   49 +
>  include/trace/events/writeback.h |  179 +++++
>  mm/backing-dev.c                 |   51 +
>  mm/memory_hotplug.c              |    3
>  mm/page-writeback.c              |  980 +++++++++++++++++++++++------
>  8 files changed, 1085 insertions(+), 211 deletions(-)
>
> Thanks,
> Fengguang
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

I pulled your tree into linux-next (next-20110415) on an i386 Debian host.

My build breaks here:
...
  MODPOST vmlinux.o
  GEN     .version
  CHK     include/generated/compile.h
  UPD     include/generated/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
mm/built-in.o: In function `bdi_position_ratio':
page-writeback.c:(.text+0x5c83): undefined reference to `__udivdi3'
mm/built-in.o: In function `calc_period_shift.part.10':
page-writeback.c:(.text+0x6446): undefined reference to `____ilog2_NaN'
make[4]: *** [.tmp_vmlinux1] Error

BTW, which kernel-config options have to be set besides
CONFIG_BLK_DEV_THROTTLING=y?

- Sedat -

View attachment "config_writeback-dirty-throttling-v7.txt" of type "text/plain" (88038 bytes)