linux-kernel - Re: [PATCH 00/12] IO-less dirty throttling v7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110417014430.GA9419@localhost>
Date:	Sun, 17 Apr 2011 09:44:30 +0800
From:	Wu Fengguang <fengguang.wu@...el.com>
To:	"sedat.dilek@...il.com" <sedat.dilek@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, Jan Kara <jack@...e.cz>,
	Christoph Hellwig <hch@....de>,
	Trond Myklebust <Trond.Myklebust@...app.com>,
	Dave Chinner <david@...morbit.com>,
	Theodore Ts'o <tytso@....edu>,
	Chris Mason <chris.mason@...cle.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Mel Gorman <mel@....ul.ie>, Rik van Riel <riel@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Greg Thelen <gthelen@...gle.com>,
	Minchan Kim <minchan.kim@...il.com>,
	Vivek Goyal <vgoyal@...hat.com>,
	Andrea Righi <arighi@...eler.com>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	linux-mm <linux-mm@...ck.org>,
	"linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 00/12] IO-less dirty throttling v7

Hi Sedat,

On Sun, Apr 17, 2011 at 12:27:58AM +0800, Sedat Dilek wrote:

> I pulled your tree into linux-next (next-20110415) on an i386 Debian host.
> 
> My build breaks here:
> ...
>   MODPOST vmlinux.o
>   GEN     .version
>   CHK     include/generated/compile.h
>   UPD     include/generated/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> mm/built-in.o: In function `bdi_position_ratio':
> page-writeback.c:(.text+0x5c83): undefined reference to `__udivdi3'

Yes it can be fixed by the attached patch.

> mm/built-in.o: In function `calc_period_shift.part.10':
> page-writeback.c:(.text+0x6446): undefined reference to `____ilog2_NaN'

I cannot reproduce this error. In the git tree, calc_period_shift() is
actually quite simple:

static int calc_period_shift(void)                
{                                                 
        return 2 + ilog2(default_backing_dev_info.avg_write_bandwidth);
}

where avg_write_bandwidth is of type "unsigned long".

> make[4]: *** [.tmp_vmlinux1] Error
> 
> BTW, which kernel-config options have to be set besides
> CONFIG_BLK_DEV_THROTTLING=y?

No. I used your kconfig on 2.6.39-rc3 and it compiles OK for i386.

I've pushed two patches into the git tree fixing the compile errors.
Thank you for trying it out and report!

Thanks,
Fengguang

View attachment "bdi_position_ratio-__udivdi3-fix" of type "text/plain" (1097 bytes)