linux-kernel - [PATCH -next] hid-example: fix some build issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110418111251.8a922b6b.randy.dunlap@oracle.com>
Date:	Mon, 18 Apr 2011 11:12:51 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org
Cc:	akpm@...ux-foundation.org, jkosina@...e.cz,
	Alan Ott <alan@...nal11.us>
Subject: [PATCH -next] hid-example: fix some build issues

From: Randy Dunlap <randy.dunlap@...cle.com>

samples/hid-example.o needs some Kconfig and Makefile additions
in order to build.  It should use <linux/*.h> headers from
the build tree, so use HEADERS_CHECK to require that those
header files be present.

Change the kconfig symbol from tristate to bool since
userspace cannot be built as loadable modules.

However, I don't understand why the userspace header files are
not present as reported in Andrew's build log, since it builds
OK on x86_64 without any of these changes.

Reported-by: Andrew Morton <akpm@...ux-foundation.org>
Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
Cc: Alan Ott <alan@...nal11.us>
Cc: Jiri Kosina <jkosina@...e.cz>
Cc: linux-input@...r.kernel.org
---
 samples/Kconfig         |    4 ++--
 samples/hidraw/Makefile |    2 ++
 2 files changed, 4 insertions(+), 2 deletions(-)

--- linux-next-20110418.orig/samples/hidraw/Makefile
+++ linux-next-20110418/samples/hidraw/Makefile
@@ -6,3 +6,5 @@ hostprogs-y := hid-example
 
 # Tell kbuild to always build the programs
 always := $(hostprogs-y)
+
+HOSTCFLAGS_hid-example.o += -I$(objtree)/usr/include
--- linux-next-20110418.orig/samples/Kconfig
+++ linux-next-20110418/samples/Kconfig
@@ -62,8 +62,8 @@ config SAMPLE_KDB
 	  command to the kdb shell.
 
 config SAMPLE_HIDRAW
-	tristate "Build simple hidraw example"
-	depends on HIDRAW
+	bool "Build simple hidraw example"
+	depends on HIDRAW && HEADERS_CHECK
 	help
 	  Build an example of how to use hidraw from userspace.
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/