linux-kernel - Re: [PATCH -next] hid-example: fix some build issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Apr 2011 10:48:26 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alan Ott <alan@...nal11.us>, Michal Marek <mmarek@...e.cz>
Subject: Re: [PATCH -next] hid-example: fix some build issues


[ adding Michal Marek to CC ]

On Mon, 18 Apr 2011, Randy Dunlap wrote:

> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> samples/hid-example.o needs some Kconfig and Makefile additions
> in order to build.  It should use <linux/*.h> headers from
> the build tree, so use HEADERS_CHECK to require that those
> header files be present.
> 
> Change the kconfig symbol from tristate to bool since
> userspace cannot be built as loadable modules.
> 
> However, I don't understand why the userspace header files are
> not present as reported in Andrew's build log, since it builds
> OK on x86_64 without any of these changes.

Yes, I have no idea how the build failure Andrew is reporting happens. 
Andrew -- what exact command are you using that leads to that failure?

Thanks.

> 
> Reported-by: Andrew Morton <akpm@...ux-foundation.org>
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> Cc: Alan Ott <alan@...nal11.us>
> Cc: Jiri Kosina <jkosina@...e.cz>
> Cc: linux-input@...r.kernel.org
> ---
>  samples/Kconfig         |    4 ++--
>  samples/hidraw/Makefile |    2 ++
>  2 files changed, 4 insertions(+), 2 deletions(-)
> 
> --- linux-next-20110418.orig/samples/hidraw/Makefile
> +++ linux-next-20110418/samples/hidraw/Makefile
> @@ -6,3 +6,5 @@ hostprogs-y := hid-example
>  
>  # Tell kbuild to always build the programs
>  always := $(hostprogs-y)
> +
> +HOSTCFLAGS_hid-example.o += -I$(objtree)/usr/include
> --- linux-next-20110418.orig/samples/Kconfig
> +++ linux-next-20110418/samples/Kconfig
> @@ -62,8 +62,8 @@ config SAMPLE_KDB
>  	  command to the kdb shell.
>  
>  config SAMPLE_HIDRAW
> -	tristate "Build simple hidraw example"
> -	depends on HIDRAW
> +	bool "Build simple hidraw example"
> +	depends on HIDRAW && HEADERS_CHECK
>  	help
>  	  Build an example of how to use hidraw from userspace.
>  
> 

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/