linux-kernel - Re: [PATCH -next] hid-example: fix some build issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110419091329.GB13661@sepie.suse.cz>
Date:	Tue, 19 Apr 2011 11:13:29 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Alan Ott <alan@...nal11.us>
Subject: Re: [PATCH -next] hid-example: fix some build issues

On Tue, Apr 19, 2011 at 10:48:26AM +0200, Jiri Kosina wrote:
> 
> [ adding Michal Marek to CC ]
> 
> On Mon, 18 Apr 2011, Randy Dunlap wrote:
> 
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> > 
> > samples/hid-example.o needs some Kconfig and Makefile additions
> > in order to build.  It should use <linux/*.h> headers from
> > the build tree, so use HEADERS_CHECK to require that those
> > header files be present.
> > 
> > Change the kconfig symbol from tristate to bool since
> > userspace cannot be built as loadable modules.
> > 
> > However, I don't understand why the userspace header files are
> > not present as reported in Andrew's build log, since it builds
> > OK on x86_64 without any of these changes.
> 
> Yes, I have no idea how the build failure Andrew is reporting happens. 
> Andrew -- what exact command are you using that leads to that failure?

I believe Andrew was trying to build samples/hidraw/hid-example.o
directly, which unfortunatelly does not work (kbuild limitation). For
reference, this is the reply I sent privately to Andrew:

| The samples/hidraw/ directory does not appear in the output, I I guess 
| samples/hidraw/hid-example already existed? Back to the original 
| problem, I can reproduce the bug with
| 
| $ make  samples/hidraw/hid-example.o
|    CHK     include/linux/version.h
|    CHK     include/generated/utsrelease.h
|    CALL    scripts/checksyscalls.sh
|    CC      samples/hidraw/hid-example.o
| samples/hidraw/hid-example.c:29:23: fatal error: sys/ioctl.h: No such 
| file or directory
| 
| Because for %.o there is a rule in the toplevel Makefile passes control 
| to scripts/Makefile.build, while you would need scripts/Makefile.host in 
| this case. I don't know how to fix this, when Makefile.build is told to 
| build foo.o, it builds it as kernel code, it doesn't inspect the 
| hostprogs-y variable to see if perhaps foo.o is in the foodchain of some 
| host program. However, 'make  samples/hidraw/' works fine for me. So 
| what command exactly did you use?

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/