linux-kernel - Re: [105/105] nfsd4: fix oops on lock failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87vcybgt6u.fsf@devron.myhome.or.jp>
Date:	Tue, 19 Apr 2011 06:12:25 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	"J. Bruce Fields" <bfields@...hat.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Greg KH <gregkh@...e.de>, linux-kernel@...r.kernel.org,
	stable@...nel.org, akpm@...ux-foundation.org,
	alan@...rguk.ukuu.org.uk, Neil Brown <neilb@...e.de>,
	linux-nfs@...r.kernel.org
Subject: Re: [105/105] nfsd4: fix oops on lock failure

OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> writes:

> OGAWA Hirofumi <hirofumi@...l.parknet.co.jp> writes:
>
>>> commit 5152c8a947359758862d4631863e68e83ec01048
>>> Author: J. Bruce Fields <bfields@...hat.com>
>>> Date:   Fri Apr 15 18:08:26 2011 -0400
>>> 
>>>     nfsd4: fix struct file leak on delegation
>>>     
>>>     Introduced by acfdf5c383b38f7f4dddae41b97c97f1ae058f49.
>>>     
>>>     Cc: stable@...nel.org
>>>     Reported-by: Gerhard Heift <ml-nfs-linux-20110412-ef47@...ift.de>
>>>     Signed-off-by: J. Bruce Fields <bfields@...hat.com>
>>> 
>>> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
>>> index aa309aa..c79a983 100644
>>> --- a/fs/nfsd/nfs4state.c
>>> +++ b/fs/nfsd/nfs4state.c
>>> @@ -258,6 +258,7 @@ static void nfs4_put_deleg_lease(struct nfs4_file *fp)
>>>  	if (atomic_dec_and_test(&fp->fi_delegees)) {
>>>  		vfs_setlease(fp->fi_deleg_file, F_UNLCK, &fp->fi_lease);
>>>  		fp->fi_lease = NULL;
>>> +		fput(fp->fi_deleg_file);
>>>  		fp->fi_deleg_file = NULL;
>>>  	}
>>>  }
>
> For now, I feel this explain filp leak on my system. the leak is
> increased slowly (filp, cred_jar, and no nfs* slabs), and leak is on
> nfs server side.
>
> I'll start test of this patch, and see what happens.

OK. Although filp slabs are still slightly increasing (I'm not sure yet
whether this is leak of filp on system). But watching before/after
patch, the graph of filp slabs is clearly different.

As far as I can say patches are fine.

Thanks.
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/