linux-kernel - Re: [PATCH] drivers/spi/atmel_spi.c: prevent premature irqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DABF65C.5070607@atmel.com>
Date:	Mon, 18 Apr 2011 10:29:16 +0200
From:	Nicolas Ferre <nicolas.ferre@...el.com>
To:	"Voss, Nikolaus" <N.Voss@...nmann.de>
CC:	"'Linux Kernel'" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/spi/atmel_spi.c: prevent premature irqs

Le 11/04/2011 11:38, Voss, Nikolaus :
> Hi,
> 
>> What about something like this?
>>
>> /* disable all interrupts to avoid premature irq triggering */
>> spi_writel(as, IDR, 0xffffffff);
> 
> I implemented it this way the first time, but on a second approach I used
> the more specific variant.
> 
> That way it is kept symmetric to the irq enable part in the transfer method
> which enables no more than the irqs disabled in my patch. And I generally
> feel better when not writing live values to don't care bits ;-).

That makes sense. I add my ACK.

Bye,
-- 
Nicolas Ferre

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/