[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4DAD72A7.90904@cam.ac.uk>
Date: Tue, 19 Apr 2011 12:31:51 +0100
From: Jonathan Cameron <jic23@....ac.uk>
To: Rusty Russell <rusty@...tcorp.com.au>
CC: linux-kernel@...r.kernel.org, greg@...ah.com, adobriyan@...il.com
Subject: Re: [PATCH 1/3] Add a usr_strtobool function matching semantics of
existing in kernel equivalents
On 04/19/11 02:36, Rusty Russell wrote:
> On Thu, 24 Mar 2011 13:23:43 +0000, Jonathan Cameron <jic23@....ac.uk> wrote:
>> This is a renamed and relocated fixed version of previous kstrtobool RFC
>
> Please just call it strtobool, usr_ implies it's a user pointer.
Will do. I guess that is still distinct enough from kstrto* to avoid
anyone expecting the semantics from this one.
>
> And there's no need to introduce a new var in debugfs, just do:
>
> if (strtobool(buf, &bv) == 0)
> *val = bv;
Excellent point.
>
> And yes, I'll take it for the param stuff.
Thanks. New version coming shortly.
>
> Thanks,
> Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists