[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110419112933.GA18660@elte.hu>
Date: Tue, 19 Apr 2011 13:29:33 +0200
From: Ingo Molnar <mingo@...e.hu>
To: Robert Richter <robert.richter@....com>
Cc: Peter Zijlstra <peterz@...radead.org>,
Stephane Eranian <eranian@...gle.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] perf, x86: Fix event scheduler for constraints with
overlapping counters
* Robert Richter <robert.richter@....com> wrote:
> + if (!state)
> + /* no events to reschedule */
> + goto done;
Hm, that's 5 levels of indentation. Would it be possible to factor out the gist
of the logic into a helper and such? My eyes would be much happier!
Thanks,
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists