linux-kernel - RE: [PATCH 13/14] regulator: check name in initialization of max8925

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <25B60CDC2F704E4E9D88FFD52780CB4C05CF05B529@SC-VEXCH1.marvell.com>
Date:	Tue, 19 Apr 2011 04:33:42 -0700
From:	Haojian Zhuang <hzhuang1@...vell.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Haojian Zhuang <haojian.zhuang@...il.com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"dmitry.torokhov@...il.com" <dmitry.torokhov@...il.com>,
	"a.zummo@...ertech.it" <a.zummo@...ertech.it>,
	"johnpol@....mipt.ru" <johnpol@....mipt.ru>,
	"cbou@...l.ru" <cbou@...l.ru>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"lrg@...mlogic.co.uk" <lrg@...mlogic.co.uk>
Subject: RE: [PATCH 13/14] regulator: check name in initialization of	max8925



>-----Original Message-----
>From: Mark Brown [mailto:broonie@...nsource.wolfsonmicro.com]
>Sent: 2011年4月19日 6:51 PM
>To: Haojian Zhuang
>Cc: Haojian Zhuang; sameo@...ux.intel.com; linux-kernel@...r.kernel.org;
>dmitry.torokhov@...il.com; a.zummo@...ertech.it; johnpol@....mipt.ru;
>cbou@...l.ru; dwmw2@...radead.org; lrg@...mlogic.co.uk
>Subject: Re: [PATCH 13/14] regulator: check name in initialization of
>max8925
>
>On Tue, Apr 19, 2011 at 01:28:23AM -0700, Haojian Zhuang wrote:
>
>> >> 	There's issue in max8925_core.c since we can't assume regulator[0]
>> >always declared in machine driver.
>
>> >What is the issue?  It's trivial to skip the regulator if the data is
>> >null.
>
>> It skiped all regulators if regulator[0] isn't decleared.
>> 	(pdata == NULL) || (pdata->regulator[0] == NULL)
>
>> So it's a bug.
>
>Surely the obvious fix is to fix the issue and not skip all the
>regulators if an individual regulator has no data?

Yes.