| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110419201950.GA9725@suse.de> Date: Tue, 19 Apr 2011 13:19:50 -0700 From: Greg KH <gregkh@...e.de> To: Guenter Roeck <guenter.roeck@...csson.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, Jonathan Cameron <kernel@...23.retrosnub.co.uk>, Randy Dunlap <rdunlap@...otime.net>, linux-doc@...r.kernel.org, linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] misc: Driver for Silicon Labs Si570 and compatibles On Tue, Apr 19, 2011 at 01:30:22PM -0700, Guenter Roeck wrote: > This driver adds support for Si570, Si571, Si598, and Si599 > programmable XO/VCXO. > > Signed-off-by: Guenter Roeck <guenter.roeck@...csson.com> > --- > Documentation/misc-devices/si570 | 61 ++++++ > MAINTAINERS | 7 + > drivers/misc/Kconfig | 10 + > drivers/misc/Makefile | 1 + > drivers/misc/si570.c | 398 ++++++++++++++++++++++++++++++++++++++ > include/linux/i2c/si570.h | 23 +++ This file should be in include/linux/platform_data/, right? And as you have created sysfs files, you need to also provide the proper Documentation/ABI/ files. Please add them in your next resend of this patch. Also, please run your patch through scripts/checkpatch.pl before sending it out, and fix the issues it finds, otherwise people will just repeat them here, which is boring... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists