linux-kernel - Re: [PATCH 1/2] x86, MCE: Do not taint when handling correctable errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110421095114.GB10263@aftab>
Date:	Thu, 21 Apr 2011 11:51:14 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	"Chumbalkar, Nagananda" <Nagananda.Chumbalkar@...com>,
	Borislav Petkov <bp@...64.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Prarit Bhargava <prarit@...hat.com>,
	Tony Luck <tony.luck@...el.com>, Russ Anderson <rja@....com>,
	LKML <linux-kernel@...r.kernel.org>,
	EDAC devel <linux-edac@...r.kernel.org>
Subject: Re: [PATCH 1/2] x86, MCE: Do not taint when handling correctable
 errors

On Thu, Apr 21, 2011 at 05:35:54AM -0400, Ingo Molnar wrote:
> 
> * Chumbalkar, Nagananda <Nagananda.Chumbalkar@...com> wrote:
> 
> > Would it be okay to extend this reasoning and also remove the tainting 
> > caused by TM1/TM2 thermal events:
> > 
> > diff --git a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > index 6f8c5e9..9f3b5ae 100644
> > --- a/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > +++ b/arch/x86/kernel/cpu/mcheck/therm_throt.c
> > @@ -188,7 +188,6 @@ static int therm_throt_process(bool new_event, int event,
> > int level)
> >                                 level == CORE_LEVEL ? "Core" : "Package",
> >                                 state->count);
> > 
> > -               add_taint(TAINT_MACHINE_CHECK);
> >                 return 1;
> >         }
> >         if (old_event) {
> > @@ -393,7 +392,6 @@ static void unexpected_thermal_interrupt(void)
> > {
> >         printk(KERN_ERR "CPU%d: Unexpected LVT thermal interrupt!\n",
> >                         smp_processor_id());
> > -       add_taint(TAINT_MACHINE_CHECK);
> > }
> 
> Mind sending a proper patch, with changelog, signoff, acks, etc?

No need since this is part of 7b70bd3441437b7bc04fc9d321e17c8ed0e8f958
now which is in tip/x86/mce.

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/