linux-kernel - Re: Question: GPIO driver how to get irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110421134524.GA32725@ponder.secretlab.ca>
Date:	Thu, 21 Apr 2011 07:45:24 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Tomoya MORINAGA <tomoya-linux@....okisemi.com>,
	linux-kernel@...r.kernel.org, toshiharu-linux@....okisemi.com
Subject: Re: Question: GPIO driver how to get irq_base

On Thu, Apr 21, 2011 at 10:09:14AM +0200, Lars-Peter Clausen wrote:
> On 04/21/2011 09:32 AM, Tomoya MORINAGA wrote:
> > Hi GPIO maintainer,
> > 
> > Need your help.
> > I want to add interrupt function to gpio/pch_gpio.c
> > 
> > According to other upstreamed GPIO driver, (e.g. pl061, langwell, etc...)
> > 2 IRQs(irq, irq_base) are used.

irq and irq_base are two different things.  irq is the irq number that
the gpio expander is wired up to.  irq_base is the starting range for
any irqs generated by the gpio expender.  Essentially, turning the
gpio controller into an irq controller.

> > 
> > I can get "irq" from (struct pci_dev *)pdev->irq.
> > However I can't understand where can I get the "irq_base".
> > Let me know how to get.
> > 
> > Thanks,
> > -----------------------------------------
> > Tomoya MORINAGA
> > OKI SEMICONDUCTOR CO., LTD.
> 
> In my opinion the best option for expander chips is to allocate a new irq_desc
> range by calling irq_alloc_descs. It will return the first irq number in the
> newly allocated range, which will be your irq_base.

Yes, irq_alloc_descs() will give you a range of irqs that the gpio
expander can use.  In many drivers, the irq_base is hard coded in the
board file and passed in via pdata, but as much as possible I
recommend avoiding that and letting Linux dynamically allocate the
irq_base for you.  Setting gpio_base to -1 will do this.

The ->to_irq() hook in your driver can translate
from a gpio number to an irq number for a specific gpio.

> But be aware that this will require SPARSE_IRQ to work.

Why?

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/