linux-kernel - Re: [PATCH -tip] perf, x86: P4 PMU - Don't forget to clear cpuc->active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110421135742.GZ20887@redhat.com>
Date:	Thu, 21 Apr 2011 09:57:42 -0400
From:	Don Zickus <dzickus@...hat.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Lin Ming <ming.m.lin@...el.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] perf, x86: P4 PMU - Don't forget to clear
 cpuc->active_mask on overflow

On Thu, Apr 21, 2011 at 03:17:48PM +0200, Ingo Molnar wrote:
> 
> * Don Zickus <dzickus@...hat.com> wrote:
> 
> > On Wed, Apr 20, 2011 at 07:13:37PM +0400, Cyrill Gorcunov wrote:
> > > It's not enough to simply disable event on overflow the cpuc->active_mask
> > > should be cleared as well otherwise counter may stall in "active" even
> > > in real being already disabled (which potentially may lead to the situation
> > > that user may not use this counter further).
> > 
> > I also noticed this patch fixed some unknown NMIs on a P4 when I stressed
> > the box
> > 
> > Acked-by: Don Zickus <dzickus@...hat.com>
> 
> Ok. Mind one of you resending all pending patches in this area, with all 
> Acked-by's and Tested-by's in place?

Cyril is that something you can do because I think all of these patches
revolve around P4 fixes?  Though I don't know what are all the patches.  I
know I had one and this patch.  Is there another on Cyril?

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/