linux-kernel - Re: [PATCH -tip] perf, x86: P4 PMU - Don't forget to clear cpuc->active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DB03809.50806@openvz.org>
Date:	Thu, 21 Apr 2011 17:58:33 +0400
From:	Cyrill Gorcunov <gorcunov@...nvz.org>
To:	Don Zickus <dzickus@...hat.com>
CC:	Ingo Molnar <mingo@...e.hu>, Lin Ming <ming.m.lin@...el.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip] perf, x86: P4 PMU - Don't forget to clear cpuc->active_mask
 on overflow

On 04/21/2011 05:17 PM, Ingo Molnar wrote:
> 
> * Don Zickus <dzickus@...hat.com> wrote:
> 
>> On Wed, Apr 20, 2011 at 07:13:37PM +0400, Cyrill Gorcunov wrote:
>>> It's not enough to simply disable event on overflow the cpuc->active_mask
>>> should be cleared as well otherwise counter may stall in "active" even
>>> in real being already disabled (which potentially may lead to the situation
>>> that user may not use this counter further).
>>
>> I also noticed this patch fixed some unknown NMIs on a P4 when I stressed
>> the box
>>
>> Acked-by: Don Zickus <dzickus@...hat.com>
> 
> Ok. Mind one of you resending all pending patches in this area, with all 
> Acked-by's and Tested-by's in place?
> 
> I'd like to ask one more thing as well: please submit the patches in a single 
> e-mail thread - i.e. with a proper 0/N and e-mail threading, so that anyone can 
> see that they are a group of patches. Current submissions are various versions 
> of patches with no clear grouping.
> 
> Thanks,
> 
> 	Ingo

Don, will you pick it up in addition to your unknown NMI fast-fix?

-- 
    Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/