[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110422203434.GA2977@quack.suse.cz>
Date: Fri, 22 Apr 2011 22:34:34 +0200
From: Jan Kara <jack@...e.cz>
To: Chris Mason <chris.mason@...cle.com>
Cc: djwong <djwong@...ibm.com>, Mingming Cao <cmm@...ibm.com>,
Christoph Hellwig <hch@...radead.org>,
Jeff Layton <jlayton@...hat.com>, Jan Kara <jack@...e.cz>,
Dave Chinner <david@...morbit.com>,
Joel Becker <jlbec@...lplan.org>,
"Martin K. Petersen" <martin.petersen@...cle.com>,
Jens Axboe <axboe@...nel.dk>,
linux-kernel <linux-kernel@...r.kernel.org>,
linux-fsdevel <linux-fsdevel@...r.kernel.org>,
Mingming Cao <mcao@...ibm.com>,
linux-scsi <linux-scsi@...r.kernel.org>,
Dave Hansen <dave@...ux.vnet.ibm.com>
Subject: Re: [RFC v2] block integrity: Stabilize(?) pages during writeback
On Fri 22-04-11 08:50:01, Chris Mason wrote:
> Excerpts from Darrick J. Wong's message of 2011-04-21 20:02:26 -0400:
> > Hi everyone,
> >
> > I've finally managed to get together a patch that seems to provide stable pages
> > during writeback, or at least gets us to the point that after several days of
> > running tests I don't see DIF checksum errors anymore. :)
> >
> > The last two pieces to go into this puzzle were (a) bio_integrity_prep needs to
> > walk the process tree to find all userland ptes that map to a particular memory
> > page and revoke write access, and
>
> Hmm, did you need the bio_integrity_prep change for all the filesystems?
> This should be happening already as part of using page_mkwrite.
Or more precisely page_mkclean() should do what you try to do in
bio_integrity_prep()... It would certainly be interesting (bug) if you
could write to the page after calling page_mkclean() without page_mkwrite()
being called.
Honza
--
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists