linux-kernel - RE: [PATCH 2/2] misc: add real function open/read/write/ioctl/close for moxa_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1303699643.1745.7.camel@Joe-Laptop>
Date:	Sun, 24 Apr 2011 19:47:23 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jimmy Chen (陳永達) 
	<jimmy.chen@...a.com>
Cc:	linux-kernel@...r.kernel.org, gregkh@...e.de
Subject: RE: [PATCH 2/2] misc: add real function
 open/read/write/ioctl/close for moxa_serial_io driver

On Mon, 2011-04-25 at 10:35 +0800, Jimmy Chen (陳永達) wrote:
> Add real function and GPL license.
> Signed-off-by: Jimmy Chen <jimmy.chen@...a.com>

A few things.

o Your patches are reversed.
o Please run your patches through checkpatch.
o I think it better to avoid duplicating all of the GPL
  and just reference it as you have via MODULE_LICENSE.
o You could probably use MODULE_LICENSE("GPL V2")
  if you want to limit it to V2 only.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/