linux-kernel - Re: [PATCH 2/2] misc: add real function open/read/write/ioctl/close for moxa_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110425030141.GA23658@suse.de>
Date:	Sun, 24 Apr 2011 20:01:41 -0700
From:	Greg KH <gregkh@...e.de>
To:	Jimmy Chen (陳永達) <jimmy.chen@...a.com>,
	linux-kernel@...r.kernel.org
Cc:	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH 2/2] misc: add real function open/read/write/ioctl/close
 for moxa_serial_io driver

On Sun, Apr 24, 2011 at 07:47:23PM -0700, Joe Perches wrote:
> On Mon, 2011-04-25 at 10:35 +0800, Jimmy Chen (陳永達) wrote:
> > Add real function and GPL license.
> > Signed-off-by: Jimmy Chen <jimmy.chen@...a.com>
> 
> A few things.
> 
> o Your patches are reversed.
> o Please run your patches through checkpatch.
> o I think it better to avoid duplicating all of the GPL
>   and just reference it as you have via MODULE_LICENSE.
> o You could probably use MODULE_LICENSE("GPL V2")
>   if you want to limit it to V2 only.

And finally, why does this need to be a kernel driver at all?  Can't you
do all of this from userspace without any kernel changes needed?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/