linux-kernel - Re: [PATCH] x86, vdso: SHN_LORESERVE is an inclusive lower bound

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4DB5F17C.8040105@goop.org>
Date:	Mon, 25 Apr 2011 15:11:08 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Anders Kaseorg <andersk@...lice.com>
CC:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86, vdso: SHN_LORESERVE is an inclusive lower bound

On 04/25/2011 07:28 AM, Anders Kaseorg wrote:
> Test for >= SHN_LORESERVE instead of > SHN_LORESERVE.

Yep, seems reasonable.  Did this cause a problem, or is it just
something you noticed?

    J

> Signed-off-by: Anders Kaseorg <andersk@...lice.com>
> ---
>  arch/x86/vdso/vdso32-setup.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/vdso/vdso32-setup.c b/arch/x86/vdso/vdso32-setup.c
> index 468d591..226bfad 100644
> --- a/arch/x86/vdso/vdso32-setup.c
> +++ b/arch/x86/vdso/vdso32-setup.c
> @@ -88,7 +88,7 @@ static __init void reloc_symtab(Elf32_Ehdr *ehdr,
>  		    sym->st_shndx == SHN_ABS)
>  			continue;  /* skip */
>  
> -		if (sym->st_shndx > SHN_LORESERVE) {
> +		if (sym->st_shndx >= SHN_LORESERVE) {
>  			printk(KERN_INFO "VDSO: unexpected st_shndx %x\n",
>  			       sym->st_shndx);
>  			continue;

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/