linux-kernel - Re: [BUG] perf and kmemcheck : fatal combination

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110426080443.GA806@elte.hu>
Date:	Tue, 26 Apr 2011 10:04:43 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Paul Mackerras <paulus@...ba.org>,
	Pekka Enberg <penberg@...nel.org>,
	Vegard Nossum <vegardno@....uio.no>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [BUG] perf and kmemcheck : fatal combination


* Peter Zijlstra <a.p.zijlstra@...llo.nl> wrote:

> On Mon, 2011-04-25 at 18:08 +0200, Eric Dumazet wrote:
> > Hi guys
> > 
> > Just got a panic on a kmemcheck kernel, latest linux-2.6 tree.
> > 
> > I forgot I had kmemcheck enabled, and started "perf top" just because my
> > machine was damn slow... Oh well...
> > 
> > Crash in do_nmi -> nmi_enter() -> BUG_ON(in_nmi());
> 
> Hmm,. I bet because kmemcheck triggers faults from nmi context because
> it messes about with the page protection bits a lot to track things.
> 
> Can't really think of anything except not making perf available on
> kmemcheck kernels.
> 
> ---
>  init/Kconfig |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index 32745bf..94735b4 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1125,6 +1125,7 @@ config PERF_EVENTS
>  	bool "Kernel performance events and counters"
>  	default y if (PROFILING || PERF_COUNTERS)
>  	depends on HAVE_PERF_EVENTS
> +	depends on !KMEMCHECK
>  	select ANON_INODES
>  	select IRQ_WORK
>  	help

Eric, does it manage to limp along if you remove the BUG_ON()?

That risks NMI recursion but maybe it allows you to see why things are slow, 
before it crashes ;-)

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/