linux-kernel - RE: [PATCH 2/2] misc: add real function open/read/write/ioctl/close for moxa_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ECB3782BB8F03341905DD923270296115F6A7D@mhqms01.moxa.com>
Date:	Tue, 26 Apr 2011 17:01:23 +0800
From:	Jimmy Chen (陳永達) <jimmy.chen@...a.com>
To:	<linux-kernel@...r.kernel.org>
Cc:	"Joe Perches" <joe@...ches.com>,
	"Alan Cox" <alan@...rguk.ukuu.org.uk>, "Greg KH" <gregkh@...e.de>
Subject: RE: [PATCH 2/2] misc: add real function open/read/write/ioctl/close for moxa_serial_io driver

Greg,
	Thank for the advices. Yes, we think of accessing the I/O in user space level (http://www.faqs.org/docs/Linux-mini/IO-Port-Programming.html#s1). However, the driver has been used for many years in our product including ARM9/ARM11 series platform (note that #ifdef code have been removed in this patch). That the reason why we expect to remain the consistency during user access. Also, the driver will be used to support different arch in the future.

Alan,
	I agree the functionality of moxa_serial_io driver is not serial driver, that why I locate the driver in misc subsystem. I'm not sure whether patching to current driver mxser/moxa/8250 in tty subsystem to support switching mode could be a good idea because different hardware approach could be used by different vendor to support switching mode.

Let me know your consideration and I will send patch 2/2 again according to Alan advice about the out_p function. Thank.

//Jimmy.Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/