linux-kernel - Re: [PATCH 2/2] misc: add real function open/read/write/ioctl/close for moxa_serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110426132041.GB13597@suse.de>
Date:	Tue, 26 Apr 2011 06:20:41 -0700
From:	Greg KH <gregkh@...e.de>
To:	Jimmy Chen (陳永達) <jimmy.chen@...a.com>
Cc:	linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH 2/2] misc: add real function open/read/write/ioctl/close
 for moxa_serial_io driver

On Tue, Apr 26, 2011 at 05:01:23PM +0800, Jimmy Chen (陳永達) wrote:
> Greg,
> Thank for the advices. Yes, we think of accessing the I/O in user
> space level
> (http://www.faqs.org/docs/Linux-mini/IO-Port-Programming.html#s1).
> However, the driver has been used for many years in our product
> including ARM9/ARM11 series platform (note that #ifdef code have been
> removed in this patch). That the reason why we expect to remain the
> consistency during user access. Also, the driver will be used to
> support different arch in the future.

Just because you created a messy/bad user/kernel interface in the past
doesn't mean we are forced to take it :)

I have been aware of this code for a very long time, and I disagreed
with it years ago when I first saw it, yet my opinion seemed to be
ignored then for this same reason.

We don't add code to the kernel that is not necessary, and this code is
not necessary at all as you can do the whole thing from userspace.
Please do it there.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/