linux-kernel - Re: [PATCH 2/2] watchdog: add real function on MOXA V2100 watchdog driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110426124444.GB17580@infomag.iguana.be>
Date:	Tue, 26 Apr 2011 14:44:44 +0200
From:	Wim Van Sebroeck <wim@...ana.be>
To:	Jimmy Chen (陳永達) <jimmy.chen@...a.com>
Cc:	linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org
Subject: Re: [PATCH 2/2] watchdog: add real function on MOXA V2100 watchdog
	driver

Hi Jimmy,

> From: Jimmy Chen <jimmy.chen@...a.com>
> 
> Add real function for watchdog driver
> 
> Signed-off-by: Jimmy Chen <jimmy.chen@...a.com>

My first remarks:
* This driver doesn't use /dev/watchdog.
* It doesn't follow the IOCTL API for watchdog devices
* It uses .ioctl and not an .unlocked_ioctl

Kind regards,
Wim.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/