linux-kernel - Re: [PATCH 02/18] perf: Add persistent event facilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110426124510.GB15076@elte.hu>
Date:	Tue, 26 Apr 2011 14:45:10 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Borislav Petkov <bp@...64.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Tony Luck <tony.luck@...el.com>,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	David Ahern <dsahern@...il.com>,
	EDAC devel <linux-edac@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Borislav Petkov <borislav.petkov@....com>
Subject: Re: [PATCH 02/18] perf: Add persistent event facilities


* Peter Zijlstra <peterz@...radead.org> wrote:

> On Sat, 2011-04-23 at 18:28 +0200, Borislav Petkov wrote:
> > From: Borislav Petkov <borislav.petkov@....com>
> > 
> > Add a barebones implementation for registering persistent events with
> > perf. For that, we don't destroy the buffers when they're unmapped and
> > we map them read-only so that multiple agents can access them.
> > 
> > Signed-off-by: Borislav Petkov <borislav.petkov@....com>
> > ---
> >  include/linux/perf_event.h |   22 ++++++++++++++++-
> >  kernel/events/Makefile     |    2 +-
> >  kernel/events/core.c       |   30 ++++++++++++++++++----
> >  kernel/events/persistent.c |   56 ++++++++++++++++++++++++++++++++++++++++++++
> >  4 files changed, 102 insertions(+), 8 deletions(-)
> >  create mode 100644 kernel/events/persistent.c
> > 
> > diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h
> > index ee9f1e7..37bfae1 100644
> > --- a/include/linux/perf_event.h
> > +++ b/include/linux/perf_event.h
> > @@ -216,8 +216,9 @@ struct perf_event_attr {
> >                                 precise_ip     :  2, /* skid constraint       */
> >                                 mmap_data      :  1, /* non-exec mmap data    */
> >                                 sample_id_all  :  1, /* sample_type all events */
> > +                               persistent     :  1, /* event always on */
> 
> But how will you find it again?
> 
> Persistent yells filesystem to me, and while we didn't use relayfs for 
> various reasons, I think we do need something like it at the current stage.

eventfs or sysfs?

We need VFS space for event hierarchy enumeration anyway (and move the current 
debugfs bits there). Persistent events could show up in that hiearachy as well.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/