linux-kernel - Re: [PATCH V3] tty/serial: add support for Xilinx PS UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110427103340.2554df83@lxorguk.ukuu.org.uk>
Date:	Wed, 27 Apr 2011 10:33:40 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	johnlinn@...cast.net
Cc:	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	michal.simek@...alogix.com, joe@...ches.com,
	grant.likely@...retlab.ca, greg@...ah.com
Subject: Re: [PATCH V3] tty/serial: add support for Xilinx PS UART

> I thought I was improving but now as I look at it further, that seems like it 
> was better and I should have stuck to that method.
> 
> Thoughts?

Go for nearest is the right behaviour. The whole tty layer works on that
basis as do soem other things. It means you don't have to have a set of
calls to do things like "enumerate valid data rates" instead you ask and
compare.

> > > +	uart_update_timeout(port, termios->c_cflag, baud);
> > 
> > [which would also fix this timeout!]
> 
> Maybe you were meaning that if the baud rate was not really set because of the
> error this timeout would be wrong also, and if so that makes sense.

Correct

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/