linux-kernel - Re: [PATCH 2/2] blkdev: Simple cleanup in blkdev_issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x4962pz4wnd.fsf@segfault.boston.devel.redhat.com>
Date:	Wed, 27 Apr 2011 10:05:42 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Lukas Czerner <lczerner@...hat.com>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Dmitry Monakhov <dmonakhov@...nvz.org>,
	Jens Axboe <jens.axboe@...cle.com>
Subject: Re: [PATCH 2/2] blkdev: Simple cleanup in blkdev_issue_zeroout()

Lukas Czerner <lczerner@...hat.com> writes:

> In blkdev_issue_zeroout() we are submitting regular WRITE bios, so we do
> not need to check for -EOPNOTSUPP specifically in case of error. Also
> there is no need to have label submit: because there is no way to jump
> out from the while cycle without an error and we really want to exit,
> rather than try again.

Looks good.  While we're at it:

	while (nr_sects != 0) {
		sz = min((sector_t) PAGE_SIZE >> 9 , nr_sects);
		if (sz == 0)
			/* bio has maximum size possible */
			break;

how could sz be equal to zero there?

Reviewed-by: Jeff Moyer <jmoyer@...hat.com>

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/