linux-kernel - Re: Undoing module RONX protection fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tyditxo8.fsf@rustcorp.com.au>
Date:	Thu, 28 Apr 2011 21:06:39 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Jan Glauber <jang@...ux.vnet.ibm.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	linux-kernel@...r.kernel.org, castet.matthieu@...e.fr,
	sliakh.lkml@...il.com, jiang@...ncsu.edu, mingo@...e.hu
Subject: Re: Undoing module RONX protection fix

On Thu, 28 Apr 2011 12:08:20 +0200, Jan Glauber <jang@...ux.vnet.ibm.com> wrote:
> How about this?
> 
> To be honest I don't like the inverse naming like in unset no-execute
> too much, it makes me feel dizzy. But I wanted to keep the changes
> minimal.

Yes, it should probably just be called protect_module_pages and
unprotect_module_pages.  The current names provide far too much
information.

But going back a bit, how did we end up with a NULL mod->module_init and
yet module->init_text_size, mod->init_size or mod->init_ro_size
non-zero?

Because if start == end, set_page_attributes() is a noop, right?

Confused,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/