linux-kernel - Re: [PATCHv4 2/7] ethtool: Call ethtool's get/set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1303994799.3032.456.camel@localhost>
Date:	Thu, 28 Apr 2011 13:46:39 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Stanislaw Gruszka <sgruszka@...hat.com>
Cc:	David Decotigny <decot@...gle.com>,
	"David S. Miller" <davem@...emloft.net>, mirq-linux@...e.qmqm.pl,
	Alexander Duyck <alexander.h.duyck@...el.com>,
	Eilon Greenstein <eilong@...adcom.com>,
	Grant Grundler <grundler@...isc-linux.org>,
	e1000-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: [PATCHv4 2/7] ethtool: Call ethtool's get/set_settings
 callbacks with cleaned data

On Thu, 2011-04-28 at 09:34 +0200, Stanislaw Gruszka wrote:
> On Wed, Apr 27, 2011 at 09:32:38PM -0700, David Decotigny wrote:
> > --- a/drivers/net/stmmac/stmmac_ethtool.c
> > +++ b/drivers/net/stmmac/stmmac_ethtool.c
> > @@ -237,13 +237,12 @@ stmmac_set_pauseparam(struct net_device *netdev,
> >  
> >  	if (phy->autoneg) {
> >  		if (netif_running(netdev)) {
> > -			struct ethtool_cmd cmd;
> > +			struct ethtool_cmd cmd = { .cmd = ETHTOOL_SSET };
> >  			/* auto-negotiation automatically restarted */
> > -			cmd.cmd = ETHTOOL_NWAY_RST;
> 
> Why did you change ETHTOOL_NWAY_RST to ETHTOOL_SSET ?

Because the function it's calling is an implementation of ETHTOOL_SSET,
not ETHTOOL_NWAY_RST.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/