linux-kernel - Re: [PATCH] Staging: Westbridge: replace custom debug macros with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.vunx85sd3l0zgt@mnazarewicz-glaptop>
Date:	Thu, 28 Apr 2011 21:40:07 +0200
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	greg@...ah.com, Sutharsan <sutharsan.tech@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-usb@...r.kernel.org, david.cross@...ress.com,
	srmt@...ress.com
Subject: Re: [PATCH] Staging: Westbridge: replace custom debug macros with
 pr_...() macros

On Thu, 28 Apr 2011 20:48:41 +0200, Sutharsan <sutharsan.tech@...il.com>  
wrote:
> @@ -2121,7 +2121,7 @@ static int cyasgadget_initialize(void)
>  	cy_as_dev->dev_handle = cyasdevice_getdevhandle();
>  	if (0 == cy_as_dev->dev_handle) {
>  		#ifndef NDEBUG
> -		cy_as_hal_print_message("<1> cy_as_gadget: "
> +		pr_debug("<1> cy_as_gadget: "
>  			"no west bridge device\n");
>  		#endif
>  		retval = -EFAULT;

That's actually incorrect.  You should not have "<1>" in the
string.  Not only that, "<1>" means that the message was actually
KERN_ALERT not KERN_DEBUG -- it looks like that is a mistake though.
At any rate, though, if you are using pr_debug() you don't need to
check for NDEBUG macro.

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@...gle.com>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/