linux-kernel - Re: [PATCH] Staging: Westbridge: replace custom debug macros with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110428194725.GB25302@kroah.com>
Date:	Thu, 28 Apr 2011 12:47:25 -0700
From:	Greg KH <greg@...ah.com>
To:	Sutharsan <sutharsan.tech@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-usb@...r.kernel.org, david.cross@...ress.com,
	srmt@...ress.com
Subject: Re: [PATCH] Staging: Westbridge: replace custom debug macros with
 pr_...() macros

On Thu, Apr 28, 2011 at 11:48:41AM -0700, Sutharsan wrote:
> >From Sutharsan Ramamoorthy <srmt@...ress.com>
> 
> This patch replaces custom debug macros with Linux kernel's pr_...() macros.

Why not use the dev_dbg() and other macros instead of these?  You do
have access to a struct device for all of these places in the code,
right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/