linux-kernel - Re: [PATCH 2.6.39-rc5] ioremap: Delay sanity check until after a successful mapping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1304020149.2697.5.camel@sbsiddha-MOBL3.sc.intel.com>
Date:	Thu, 28 Apr 2011 12:49:09 -0700
From:	Suresh Siddha <suresh.b.siddha@...el.com>
To:	"tim.gardner@...onical.com" <tim.gardner@...onical.com>
Cc:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"x86@...nel.org" <x86@...nel.org>
Subject: Re: [PATCH 2.6.39-rc5] ioremap: Delay sanity check until after a
 successful mapping

On Thu, 2011-04-28 at 10:00 -0700, Tim Gardner wrote:
> While tracking down the reason for an ioremap() failure I was
> distracted 
> by the WARN_ONCE() in __ioremap_caller(). Can we move the sanity
> check 
> later in the function until _after_ the mapping has been performed?
> 
> rtg
> -- 
> Tim Gardner tim.gardner@...onical.com
> 
> 
> 
> 
> 
> 
> 
> differences
> between files
> attachment
> (0001-ioremap-Delay-sanity-check-until-after-a-successful-.patch)
> 
> From 31dec327a254888fcd0b6aa963414b09626d3168 Mon Sep 17 00:00:00 2001
> From: Tim Gardner <tim.gardner@...onical.com>
> Date: Thu, 28 Apr 2011 10:07:51 -0600
> Subject: [PATCH] ioremap: Delay sanity check until after a successful
> mapping
> 
> Performing a WARN_ONCE() sanity check before the mapping
> is successful seems pointless if the caller sends bad values.
> A case in point is when the BIOS provides erroneous screen_info values
> causing vesafb_probe() to request an outrageuous size. The
> WARN_ONCE is then wasted on bogosity. Move the warning to a
> point where the mapping has been successfully allocated.
> 
> http://bugs.launchpad.net/bugs/772042

Sounds good to me.

Reviewed-by: Suresh Siddha <suresh.b.siddha@...el.com>

thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/