linux-kernel - Re: 2.6.39-rc5-git2 boot crashs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 30 Apr 2011 04:02:43 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Joern Engel <joern@...fs.org>, Dave Chinner <dchinner@...hat.com>,
	werner <w.landgraf@...ru>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: 2.6.39-rc5-git2 boot crashs

On Sat, Apr 30, 2011 at 03:55:45AM +0100, Al Viro wrote:

> > Hmm. super->s_freeing_list is initialized pretty late in
> > logfs_read_sb(), and any error path _before_ that point will result in
> > a "goto err1" in logfs_get_sb_device() which will do various iputs
> > etc. All without that list initialized. That would seem to be the
> > cause of this, possibly triggered by Al's changes to ->mount from
> > read_super.

Wait a bit; _can_ we get there with non-NULL ->s_master_inode et.al.?
iput(NULL) is a noop...  I don't think so, since logfs_init_journal()
is not called until after we initialize that list.

Not that I'd object against taking that initialization earlier, of course,
but there seems to be something else going on...  Which iput() it is?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/