linux-kernel - Re: [RFC 5/5] hwmon: add support for Technologic Systems TS-5500 A-D converter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110430112036.1715b351@lxorguk.ukuu.org.uk>
Date:	Sat, 30 Apr 2011 11:20:36 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc:	linux-kernel@...r.kernel.org,
	Jonas Fonseca <jonas.fonseca@...oirfairelinux.com>,
	platform-driver-x86@...r.kernel.org, linux-serial@...r.kernel.org,
	lm-sensors@...sensors.org
Subject: Re: [RFC 5/5] hwmon: add support for Technologic Systems TS-5500
 A-D converter

> +	ts5xxx_sbcinfo_set(&sbcinfo);
> +	if (5500 != sbcinfo.board_id && !sbcinfo.adc) {
> +		printk(MODULE_NAME ": Incompatible TS Board.\n");
> +		return -ENODEV

This is a symptom of creating the devices in the wrong place. If you put
all the ident/creation of boards in one place with the device creation
the drivers will cleanup and these ugly export things will go away
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/