linux-kernel - Re: [PATCH V2] xen/balloon: Memory hotplug support for Xen balloon driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110503204441.GC15775@router-fw-old.local.net-space.pl>
Date:	Tue, 3 May 2011 22:44:41 +0200
From:	Daniel Kiper <dkiper@...-space.pl>
To:	Dave Hansen <dave@...ux.vnet.ibm.com>
Cc:	Daniel Kiper <dkiper@...-space.pl>, ian.campbell@...rix.com,
	akpm@...ux-foundation.org, andi.kleen@...el.com,
	haicheng.li@...ux.intel.com, fengguang.wu@...el.com,
	jeremy@...p.org, konrad.wilk@...cle.com,
	dan.magenheimer@...cle.com, v.tolstov@...fip.ru, pasik@....fi,
	wdauchy@...il.com, rientjes@...gle.com,
	xen-devel@...ts.xensource.com, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH V2] xen/balloon: Memory hotplug support for Xen balloon driver

On Tue, May 03, 2011 at 09:32:33AM -0700, Dave Hansen wrote:
> On Tue, 2011-05-03 at 00:01 +0200, Daniel Kiper wrote:
> > @@ -448,6 +575,14 @@ static int __init balloon_init(void)
> >         balloon_stats.retry_count = 1;
> >         balloon_stats.max_retry_count = RETRY_UNLIMITED;
> >
> > +#ifdef CONFIG_XEN_BALLOON_MEMORY_HOTPLUG
> > +       balloon_stats.hotplug_pages = 0;
> > +       balloon_stats.balloon_hotplug = 0;
> > +
> > +       register_online_page_callback(&xen_online_page);
> > +       register_memory_notifier(&xen_memory_nb);
> > +#endif 
>
> This is 100% static, apparently.  XEN_BALLOON can't be a module, so I
> still don't see the point of having the un/register stuff.  

You are right to some extent. However, xen_online_page() is registered
as page onlining function only on Xen hypervisor. On bare metal
generic_online_page() is only valid page onlining function.

Additionally, I think this callback mechanism enable other balloon
implementations (KVM, VMware, ...) to easily integrate with memory
hotplug. If it comes true (I am going to propose relevant solution
maybe with more generic balloon driver for Linux Kernel somewhen;
I have some ideas, however, I must focus on more important issues
for me now) proper page onlining function (for Xen, KVM, ...) should
be registered at boot time or module load/unload (after hypervisor
detection). That is why I am insisting on run time solution.
It is an investment into the future.

Daniel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/