linux-kernel - various vmbus review comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 3 May 2011 13:46:41 -0700
From:	Greg KH <greg@...ah.com>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, virtualization@...ts.osdl.org
Subject: various vmbus review comments

I just took a quick look at the vmbus code, and have the following
comments:
	- why is count_hv_channel() even a function?
	- your .h files need to be consolidated and renamed.  You will
	  need a single hyperv.h file for include/linux/ that will
	  contain some of what the vmbus*.h files have in it, but not
	  all.  Please merge things together to have:
	  	- include/linux/hyperv.h
		   What is needed to build the drivers that attach to
		   the bus
		- drivers/staging/hv/hyperv.h
		   The local .h file will have the vmbus*.h remaining
		   stuff that is only needed by the hv_vmbus.ko module
		   to be build.
	- the instances of hv_driver structures need to be static and
	  not programatically defined, like all other USB and PCI
	  drivers are handled.
	- module reference counting.  Are you sure you got it all right
	  for the individual modules that attach to the bus?  I don't
	  see any reference counting happening, is that correct?
	- fix the sparse warnings.
	- fix the use of volatile in the ring buffer code.  It should
	  not be needed and if you are relying on it, then the code is
	  wrong.
	- fix the namespace on the ringbuffer code to show that it
	  really is only for the hyperv bus code internally.

That should be enough for at least one more set of patches for you all
to work on :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/